fix: align graph runtime API with runtime namespace#13
Merged
voltjia merged 6 commits intoJul 3, 2026
Conversation
* Align runtime API with generated wrappers * Add default runtime dispatch specialization * Refactor runtime dispatch namespace * Use Abseil status for runtime device API * Revert "Use Abseil status for runtime device API" This reverts commit a26ddff. * Address runtime dispatch review feedback * Keep runtime API list in generator * Add TensorView constructor guard test * Align runtime memcpy kind constants with CUDA API * Use CUDA-style runtime memcpy constants * Use CUDA-style runtime memcpy constants * Move TensorView tests back into core test * Remove standalone TensorView test target * Remove standalone TensorView test file * Use fully qualified runtime API names in README * style: format runtime dispatch test
87fb536 to
943be4b
Compare
Co-authored-by: Jiacheng Huang <huangjiacheng0709@outlook.com>
# Conflicts: # scripts/generate_public_headers.py # src/native/cuda/iluvatar/runtime_.h # src/native/cuda/metax/runtime_.h # src/native/cuda/moore/runtime_.h # src/native/cuda/nvidia/runtime_.h # tests/CMakeLists.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
infini::rt::runtimeso that API names matching CUDA Runtime API stay in that nested namespace.infini::rtnamespace focused on runtime-device selection APIs.Motivation
This helper PR lets
feat/graph-runtime-apiabsorb the currentmasterruntime API layout before the graph-runtime PR is rebased. It preserves the project decision that CUDA-aligned Runtime API names live underinfini::rt::runtime, while InfiniRT-specific selection APIs live directly underinfini::rt.No issue is closed directly by this PR.
Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvement (no behavioral change)refactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Test Results on Supported Platforms
Full `pytest` output (optional)
Benchmark / Performance Impact
N/A - this PR changes API placement, wrapper generation, tests, and docs; it is not performance-sensitive.
Notes for Reviewers
feat/graph-runtime-api, notmasterdirectly.infini::rt::runtime; outerinfini::rtremains available for InfiniRT-specific device-type selection APIs.36e2207ae6eaa4296b4564895648d50aaeef5453, which is compatible with #1351.